-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abr-testing): Protocol simulator, utilizes opentrons CLI to simulate and record information regarding a protocol. #16433
Conversation
…late and record information regarding a protocol.
…late and record information regarding a protocol.
…late and record information regarding a protocol.
…late and record information regarding a protocol.
|
||
with Context(analyze) as ctx: | ||
# err = open(error_output, "w") | ||
# err.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment or make more descriptive
# Prepare output file | ||
json_file_path = f"{storage_directory}\\{protocol_name}_{file_date_formatted}.json" | ||
json_file_output = open(json_file_path, "wb+") | ||
# log_output_file = f"{protocol_name}_log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line or make more descriptive
|
||
# set_api_level() | ||
if CLEAN_PROTOCOL: | ||
# set_api_level(Path(protocol_file_path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line or make more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Utilizes Opentrons CLI to simulate protocols and get information including; expected change in volume, deck labware, and module usage insights.
Test Plan and Hands on Testing
Tested tool using all abr protocols in the test-protocols folder as well as self made test-protocols to verify the accuracy of the results.
Changelog
Protocol will now comment if an aspiration belongs to air gap, to indicate that the volume should not change
Risk assessment
Low risk, this protocol simulation tool is still in it's beta, and does not change overall functionality of its dependencies.