fix(protocol-designer): fix EditInstrumentsModal issue #16421
Merged
+120
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fix some issues in EditInstruments modal.
design
https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=7300-23615&m=dev
the existing implementation put check boxes and text link button in a different row, but actually they should be in the same row from the design.
There is still a couple of buttons displaying issues in the modal. (I'm asking about that to the design team, and I will fix the issues when I get feedback)
before
after
EditInstrumentsModal is missing tests right now. (ticketed)
close RQA-3275 RQA-3276 RQA-3284
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low