-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): add thermocycler form profile cycle functionality #16418
Conversation
…ality Adds the ability to program thermocycler profile cycle steps and wires up to thermocycler step form. Closes AUTH-810
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you try to sort keys by vscode? probably cycle_step would be before cycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do it in VSCode, but I did it in an online alphabetizer and it maintains cycle
before cycle_step
. Are you seeing differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, VSCode built-in sorting is a little bit weird but at this moment we don't share vscode config with each other, so we just keep using the built-in sorting 😁
.../src/pages/Designer/ProtocolSteps/StepForm/StepTools/ThermocyclerTools/ThermocyclerCycle.tsx
Outdated
Show resolved
Hide resolved
.../src/pages/Designer/ProtocolSteps/StepForm/StepTools/ThermocyclerTools/ThermocyclerCycle.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments but the sandbox worked as expected.
lgtm!
Overview
Adds the ability to program thermocycler profile cycle steps and wires up to thermocycler step form.
TODO: add tests
Closes AUTH-810
Test Plan and Hands on Testing
Changelog
ThermocyclerCycle
component and wire up in modalReview requests
see test plan
Risk assessment
low