Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add thermocycler form profile cycle functionality #16418

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Oct 4, 2024

Overview

Adds the ability to program thermocycler profile cycle steps and wires up to thermocycler step form.

TODO: add tests

Closes AUTH-810

Test Plan and Hands on Testing

  • open PD redesign and create thermocycler step
  • verify that radio button shows for changing state or programming a profile
  • select program profile and continue
  • Sselect button under "profile steps" to open modal
  • add cycles and steps, and ensure you can add, edit, and remove steps/cycles properly. Modal and step/cycle save buttons should be disabled if form fields are in a bad state
  • save the modal and step form and export protocol
  • verify that Thermocycler steps appear in commands as expected
  • reupload the downloaded protocol to PD
  • select the programmed thermocycler step and verify that you land on step 2 of the form, with all selected fields and profile pre-populated

Changelog

  • create ThermocyclerCycle component and wire up in modal
  • refactor types
  • add logic for entering thermocycler step form on step 2 if values are populated

Review requests

see test plan

Risk assessment

low

…ality

Adds the ability to program thermocycler profile cycle steps and wires up to thermocycler step form.

Closes AUTH-810
@ncdiehl11 ncdiehl11 self-assigned this Oct 4, 2024
@ncdiehl11 ncdiehl11 requested a review from koji October 4, 2024 14:55
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 4, 2024 14:55
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner October 4, 2024 14:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you try to sort keys by vscode? probably cycle_step would be before cycle

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do it in VSCode, but I did it in an online alphabetizer and it maintains cycle before cycle_step. Are you seeing differently?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, VSCode built-in sorting is a little bit weird but at this moment we don't share vscode config with each other, so we just keep using the built-in sorting 😁

@ncdiehl11 ncdiehl11 requested a review from koji October 4, 2024 16:40
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments but the sandbox worked as expected.
lgtm!

@koji koji added the authorship label Oct 4, 2024
@ncdiehl11 ncdiehl11 merged commit 12ebf27 into edge Oct 4, 2024
18 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_thermocycler-form-cycles branch October 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants