refactor(api, robot-server): remove/ update outdated TODOs #16413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanni-t
commented
Oct 3, 2024
Comment on lines
-612
to
-613
| # TODO (spp, 2024-03-18): use true run-time param overrides once enabled | ||
| # for cli protocol simulation/ execution |
There was a problem hiding this comment.
Moved from _run_file_non_pe to _run_file_pe. Non-pe will never have RTPs
| @@ -201,7 +201,6 @@ def device_info(self) -> Mapping[str, str]: | |||
| @property | |||
| def live_data(self) -> LiveData: | |||
| return { | |||
| # TODO (spp, 2022-2-22): Revise what status includes | |||
There was a problem hiding this comment.
There's a more detailed comment at a more appropriate place in this file
| @@ -311,7 +311,6 @@ def load_adapter( | |||
|
|
|||
| return labware_core | |||
|
|
|||
| # TODO (spp, 2022-12-14): https://opentrons.atlassian.net/browse/RLAB-237 | |||
Comment on lines
-64
to
-66
| # TODO (spp, 2022-10-27): This only raises if latch status is 'idle_closed'. | ||
| # We need to update the flagger to raise if latch status is anything other | ||
| # than 'idle_open' |
There was a problem hiding this comment.
The other error is handled on next line.
Comment on lines
-40
to
-41
| # TODO (spp, 2022-10-20): name this GripperMovementHandler if it doesn't handle | ||
| # any non-gripper implementations |
There was a problem hiding this comment.
This does manual labware movement deck conflict checks too.
Comment on lines
-886
to
-887
| # TODO (spp, 2024-03-18): use true run-time param overrides once enabled | ||
| # for cli protocol simulation/ execution |
There was a problem hiding this comment.
Moved from _run_file_non_pe to _run_file_pe. Non-pe simulate will never have RTPs
Comment on lines
-79
to
-80
| # TODO (spp, 2023-01-03): update calibration field as decided after | ||
| # spike https://opentrons.atlassian.net/browse/RSS-167 |
Comment on lines
-272
to
-273
| # TODO (spp, 2023-01-06): revise according to | ||
| # https://opentrons.atlassian.net/browse/RET-1295 |
| @@ -39,7 +39,7 @@ def _build_run( | |||
| id=run_id, | |||
| createdAt=created_at, | |||
| status=state_summary.status, | |||
| actions=[], # TODO (spp, 2023-04-23): wire up actions once they are allowed | |||
There was a problem hiding this comment.
No plan for actions on maintenance runs
Comment on lines
-33
to
-34
| # TODO (spp, 2023-07-06): Implement fetching Flex's engaged motors | ||
| # https://opentrons.atlassian.net/browse/RET-1371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes TODOs that have been addressed or are no longer relevant. Updates outdated ones.
Details in comments.
Review requests
Risk assessment
None.