Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fix and test frustum_helpers.py #16406

Closed
wants to merge 1 commit into from
Closed

fix(api): fix and test frustum_helpers.py #16406

wants to merge 1 commit into from

Conversation

pmoegenburg
Copy link
Contributor

Overview

Adds tests and fixes for frustum_helpers.py methods that are needed by GeometryView for LLD Phase 3 (#16302)

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@pmoegenburg pmoegenburg self-assigned this Oct 2, 2024
@pmoegenburg pmoegenburg requested a review from a team as a code owner October 2, 2024 22:42
sfoster1
sfoster1 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and minimal to unblock. Let's go ahead with it once we fix up whatever's causing CI not to pass.

@pmoegenburg pmoegenburg closed this Oct 8, 2024
@pmoegenburg pmoegenburg deleted the fix_frustum_helpers branch October 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees

@pmoegenburg pmoegenburg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmoegenburg @sfoster1