Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow ungrip gripper labware while door is open #16394

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Oct 1, 2024

Overview

closes EXEC-734.
add ungrip command and allow queuing it and executing it while door is open.

Test Plan and Hands on Testing

  1. upload a protocol that will enter ER mode.
  2. open door.
  3. issue an ungrip command:
{
    "data": {
        "commandType": "unsafe/ungripLabware",
        "intent": "fixit",
        "params": {
        }
    }
}
  1. make sure the gripper opens its jaw.

tested with dev server and the command succeeded but still need to test with an actual gripper (@SyntaxColoring thank you Max)

Changelog

  1. added an ungrip command unsafe/ungripLabware
  2. added logic for queuing while the door is open.
  3. added logic for allowing to execute while door is open.

Review requests

  1. gripper command makes sense?
  2. logic changes make sense?

Risk assessment

medium. added a new command but need to make sure nothing has changed with the door saftey.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know it's a draft, i'm just marking changes so we don't forget to put this in schema 10 once #16401 is merged

api/src/opentrons/protocol_engine/state/commands.py Outdated Show resolved Hide resolved
shared-data/command/schemas/9.json Outdated Show resolved Hide resolved
@TamarZanzouri TamarZanzouri requested a review from sfoster1 October 2, 2024 19:31
@TamarZanzouri TamarZanzouri changed the title Exec 734 allow the gripper to be opened while the door is open feature(api): allow ungrip gripper labware while door is open Oct 2, 2024
@TamarZanzouri TamarZanzouri marked this pull request as ready for review October 2, 2024 19:38
@TamarZanzouri TamarZanzouri requested review from a team as code owners October 2, 2024 19:38
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline changes.

also is it really the case that we need to care about specifically the queue status for awaiting recovery, and specifically the engine status for AWAITING_RECOVERY_OPEN_DOOR? Can these both query the same thing?

shared-data/command/schemas/9.json Outdated Show resolved Hide resolved
api/src/opentrons/protocol_engine/state/commands.py Outdated Show resolved Hide resolved
api/src/opentrons/protocol_engine/state/commands.py Outdated Show resolved Hide resolved
@SyntaxColoring SyntaxColoring self-assigned this Oct 3, 2024
@SyntaxColoring
Copy link
Contributor

Latest commits should address the feedback above.

I did make one change to the logic, to make sure these special ungrip commands can also be queued and run when the engine status is awaiting-recovery-paused, not only when it's awaiting-recovery-blocked-by-open-door. If we're saying they're safe to run while the door is actually open, presumably they're also safe to run if the door has been closed and the closure just hasn't been "logically acknowledged" yet.

@SyntaxColoring SyntaxColoring changed the title feature(api): allow ungrip gripper labware while door is open feat(api): allow ungrip gripper labware while door is open Oct 5, 2024
@TamarZanzouri
Copy link
Contributor Author

tested with the app and postman. works as expected!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for changing the name structure!

@TamarZanzouri TamarZanzouri merged commit 7badfee into edge Oct 7, 2024
42 checks passed
@TamarZanzouri TamarZanzouri deleted the EXEC-734-allow-the-gripper-to-be-opened-while-the-door-is-open branch October 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants