-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): allow ungrip gripper labware while door is open #16394
feat(api): allow ungrip gripper labware while door is open #16394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know it's a draft, i'm just marking changes so we don't forget to put this in schema 10 once #16401 is merged
api/tests/opentrons/protocol_engine/commands/unsafe/test_ungrip_labware.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline changes.
also is it really the case that we need to care about specifically the queue status for awaiting recovery, and specifically the engine status for AWAITING_RECOVERY_OPEN_DOOR
? Can these both query the same thing?
Latest commits should address the feedback above. I did make one change to the logic, to make sure these special ungrip commands can also be queued and run when the engine status is |
tested with the app and postman. works as expected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for changing the name structure!
Overview
closes EXEC-734.
add ungrip command and allow queuing it and executing it while door is open.
Test Plan and Hands on Testing
tested with dev server and the command succeeded but still need to test with an actual gripper (@SyntaxColoring thank you Max)
Changelog
unsafe/ungripLabware
Review requests
Risk assessment
medium. added a new command but need to make sure nothing has changed with the door saftey.