feat(app,app-shell,app-shell-odd): detect user system language, add language setting to app config #16393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a config language value to desktop/ODD and initializes i18n language to the stored config value closes PLAT-504
brenthagen
requested review from
jerader
and removed request for
a team and
jerader
vegano1
approved these changes
Oct 10, 2024
brenthagen
changed the title
vegano1
approved these changes
Oct 10, 2024
| const storedSystemLanguage = useSelector(getStoredSystemLanguage) | ||
|
|
||
| // TODO(bh, 2024-10-09): desktop app, check for current system language vs stored config system language value, launch modal | ||
| console.log( |
There was a problem hiding this comment.
just a spot check, will remove in next PR that uses the system language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds a config app language value to desktop/ODD and initializes i18n language to the stored app language config value. detects the user's system language in desktop app-shell and transmits to renderer via IPC/redux. adds a system language config value.
closes PLAT-504, PLAT-497
Test Plan and Hands on Testing
updated unit tests, confirmed the config value persists and initializes language. developed on MacOS, will need to test in windows/linux before release.
Changelog
Review requests
confirm the language selection persists on app restart. do the LocalizationProvider changes make sense?
Risk assessment
medium, this changes the app-level localization provider wrapper