-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): step edit form opens on edit button #16378
Conversation
46ac729
to
1b99fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Couple of questions:
- Is intended behavior for single click a selected step when a step is selected in edit mode to close the edit toolbox?
- How do you produce the delete confirmation modal? Currently clicking the delete menu button deletes the step without confirmation
@ncdiehl11 yup! since you select on a different step.
Oops, good catch. i think i only wired up if you edited a step and clicked "cancel" on the toolbox. i'll fix this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update. looks good
closes Auth-879
Overview
Changing the edit step form behavior by adding a button but also allowing users to open it by double clicking on the step. ITs a bit buggy when clicking on other steps while editing a form though. that will be addressed in a followup
demo demonstrates opening the step with the edit step button and also double clicking
https://github.com/user-attachments/assets/88cc0a49-dc15-48af-b91c-7c9257cab02b
Test Plan and Hands on Testing
Create a protocol and add a step, now edit the step by either pressing the step button twice or clicking on the overflow menu and clicking the "edit step" button
Changelog
Risk assessment
low