Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): step edit form opens on edit button #16378

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Sep 29, 2024

closes Auth-879

Overview

Changing the edit step form behavior by adding a button but also allowing users to open it by double clicking on the step. ITs a bit buggy when clicking on other steps while editing a form though. that will be addressed in a followup

demo demonstrates opening the step with the edit step button and also double clicking
https://github.com/user-attachments/assets/88cc0a49-dc15-48af-b91c-7c9257cab02b

Test Plan and Hands on Testing

Create a protocol and add a step, now edit the step by either pressing the step button twice or clicking on the overflow menu and clicking the "edit step" button

Changelog

  • edit the logic and make a new action for populating the form individually
  • add some test coverage

Risk assessment

low

@jerader jerader requested a review from a team as a code owner September 29, 2024 15:24
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team September 29, 2024 15:24
@jerader jerader force-pushed the skunk_timeline-edit-button branch from 46ac729 to 1b99fd1 Compare September 29, 2024 18:18
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Couple of questions:

  • Is intended behavior for single click a selected step when a step is selected in edit mode to close the edit toolbox?
  • How do you produce the delete confirmation modal? Currently clicking the delete menu button deletes the step without confirmation

@jerader
Copy link
Collaborator Author

jerader commented Sep 30, 2024

Code looks good. Couple of questions:

  • Is intended behavior for single click a selected step when a step is selected in edit mode to close the edit toolbox?

@ncdiehl11 yup! since you select on a different step.

  • How do you produce the delete confirmation modal? Currently clicking the delete menu button deletes the step without confirmation

Oops, good catch. i think i only wired up if you edited a step and clicked "cancel" on the toolbox. i'll fix this!

@jerader jerader requested a review from ncdiehl11 September 30, 2024 16:25
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update. looks good

@jerader jerader merged commit 88d7237 into edge Oct 1, 2024
14 checks passed
@jerader jerader deleted the skunk_timeline-edit-button branch October 1, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants