Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-ddesigner): fix select modules unexpected behavior #16372

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 27, 2024

Overview

fix select modules unexpected behavior

the issue is coming from unmatched between modules and filteredModules.

close AUTH-743

Test Plan and Hands on Testing

Changelog

Review requests

I tried some cases from the following. But I could not find any patterns since even the same clicking order returned a different result.

@jerader @ncdiehl11, if you have any better solution, please let me know.

TC, Temp, H/S, Magnetic
TC, Temp, Magnetic, H/S
TC, H/S, Temp, Magnetic
TC, H/S, Magnetic, Temp
TC, Magnetic, Temp, H/S
TC, Magnetic, H/S, Temp
Temp, TC, H/S, Magnetic
Temp, TC, Magnetic, H/S
Temp, H/S, TC, Magnetic
Temp, H/S, Magnetic, TC
Temp, Magnetic, TC, H/S
Temp, Magnetic, H/S, TC
H/S, TC, Temp, Magnetic
H/S, TC, Magnetic, Temp
H/S, Temp, TC, Magnetic
H/S, Temp, Magnetic, TC
H/S, Magnetic, TC, Temp
H/S, Magnetic, Temp, TC
Magnetic, TC, Temp, H/S
Magnetic, TC, H/S, Temp
Magnetic, Temp, TC, H/S
Magnetic, Temp, H/S, TC
Magnetic, H/S, TC, Temp
Magnetic, H/S, Temp, TC

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader September 27, 2024 19:47
<StyledText desktopStyle="bodyLargeRegular">
{t('create_a_protocol')}
</StyledText>
<ButtonText>{t('create_a_protocol')}</ButtonText>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to avoid the following nested structure

<p>
  <p>something</p>
</p>

@koji koji marked this pull request as ready for review September 27, 2024 19:53
@koji koji requested a review from a team as a code owner September 27, 2024 19:53
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good. Just left one small comment on where an int literal is coming from

@koji koji merged commit 047d142 into edge Sep 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants