feature(api): Put command implementations in charge of PipetteStore updates for tip state and pipette config
#16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
requested review from
brenthagen
and removed request for
a team
TamarZanzouri
force-pushed
the
EXEC-733-put-command-implementations-in-charge-of-pipette-store-updates
branch
from
3e09c0a to
a213c1f
Compare
TamarZanzouri
requested review from
sfoster1 and
SyntaxColoring
and removed request for
a team and
brenthagen
sfoster1
approved these changes
Sep 27, 2024
TamarZanzouri
commented
Sep 27, 2024
| @@ -149,72 +145,32 @@ def handle_action(self, action: Action) -> None: | |||
| elif isinstance(action, SetPipetteMovementSpeedAction): | |||
| self._state.movement_speed_by_id[action.pipette_id] = action.speed | |||
|
|
|||
| def _handle_command( # noqa: C901 | |||
There was a problem hiding this comment.
proud of removing this ;-)
TamarZanzouri
deleted the
EXEC-733-put-command-implementations-in-charge-of-pipette-store-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes EXEC-733
update pipette store from command implementation for:
LoadPipetteResult
DropTipResult,
DropTipInPlaceResult,
unsafe.UnsafeDropTipInPlaceResult,
PickUpTipResult
PipetteNozzleLayoutResultMixin
PipetteConfigUpdateResultMixin for:
Test Plan and Hands on Testing
upload a protocol with the following commands/side effects and make sure its acting as expected.
Review requests
did I miss anything?
Risk assessment
Medium. need to smoke test to make sure nothing is affected.