Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): update Magnetic Module step form #16362

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Sep 26, 2024

re AUTH-812

Overview

Updating the Magnetic module step form for single module to match the design

Test Plan and Hands on Testing

  • Create an OT-2 protocol and add a magnetic module GEN1 or GEN2
  • Go to the Protocol Steps tab and add a step for Magnet
  • Text display for the min and max engage height for magnetic module GEN1 and GEN2 (only show unit when it's a GEN2)
  • Add labware to the Magnetic Module, and there might be a recommended engage height depending on the labware

Changelog

  • Added an optional caption prop to ToggleExpandStepFormField for displaying the min, max, and recommended engage height text under the input field
  • Added onToggleUpdateValue() to ToggleExpandStepFormField to handle both boolean and string values, toggling between 'engage' and 'disengage' action types
  • Updated Toolbox.tsx and other step forms to add or remove the borderBottom grey line
  • Added test

Review requests

Risk assessment

@syao1226 syao1226 marked this pull request as ready for review October 1, 2024 20:26
@syao1226 syao1226 requested review from a team as code owners October 1, 2024 20:26
@syao1226 syao1226 requested review from mjhuff, koji and jerader and removed request for a team and mjhuff October 1, 2024 20:26
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! nice work! Feel free to merge this in after the checks are done

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments
lgtm

</Flex>
</ListItem>
</Flex>
<Box borderBottom={`1px solid ${COLORS.grey30}`} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use Divider.

screen.getByText('Module')
screen.getByText('mock name')
screen.getByText('Magnet action')
screen.getByText('Engage')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MagnetTools is https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=10435-669248&m=dev, isn't it?

If so, the copies are slightly different.
I think if you can issue a ticket that has info about what things we need to update, you can merge this PR into edge when solving CI checks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean something like updating the step name from 'Magnet' to 'Magnetic'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
maybe MagneticTools?

@ncdiehl11 any suggestion?

@syao1226 syao1226 merged commit b60f8dd into edge Oct 3, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants