refactor(api): Hide implementation details from absorbance reader results #16359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This implements what was discussed in this thread.
The absorbance reader results exposed some implementation details, for technical reasons. Since #16276 has merged, those technical reasons no longer apply, so we can stop leaking the implementation details.
Test Plan and Hands on Testing
Review requests
Nothing outside of
opentrons.protocol_enginewas reading these results, right?Risk assessment
Low, if nothing outside of
opentrons.protocol_enginewas reading these results.