Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): fix deck map hardware rendering issue #16354

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix(protocol-designer): fix deck map hardware rendering issue #16354

merged 4 commits into from
Oct 1, 2024
+228 −157

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 25, 2024

Overview

fix deck map hardware rendering issue and update ProtocolMetadataNav
remove margins from DeskSetupTools

close RQA-3231 and RQA-3241

Test Plan and Hands on Testing

Changelog

  • update DeskSetupTools
  • update ProtocolMetadataNav and add its tests

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader September 25, 2024 19:15
@koji koji marked this pull request as ready for review September 25, 2024 19:17
@koji koji requested a review from a team as a code owner September 25, 2024 19:17
jerader
jerader approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messed around with adding a module/fixture and it seems to be working a lot smoother now. nice job!

@koji koji merged commit d7ae1cd into edge Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @jerader