-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api, shared-data): Add support for labware lids and publish tc lid seal labware #16345
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16345 +/- ##
===========================================
- Coverage 92.43% 79.27% -13.16%
===========================================
Files 77 118 +41
Lines 1283 4276 +2993
===========================================
+ Hits 1186 3390 +2204
- Misses 97 886 +789
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ithub.com/Opentrons/opentrons into tc-lid-engine-and-labware-def-publication
@@ -15,6 +15,8 @@ import { getLabwareDefinitionsFromCommands } from '/app/molecules/Command/utils/ | |||
|
|||
import type { RobotType } from '@opentrons/shared-data' | |||
|
|||
const filtered_labware = ['opentrons_tough_pcr_auto_sealing_lid'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snake case variable will likely fail our linter - if you change to all caps or camel case it should work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app and shared-data changes look good to me! follow-on LPC solution will be implemented in https://opentrons.atlassian.net/browse/PLAT-483
Overview
Covers PLAT-356, PLAT-264, PLAT-540
Publicizes new "opentrons_tough_pcr_auto_sealing_lid" labware. Implements the new labware allowedRole "lid" for labware, alongside "lidOffsets" subcategory of the gripper offsets in labware definition. Introduces multi-labware stacking logic to allow for stacks of up to 5 lids. Enforces existing behavior of no more than two traditional labware per stack, unless specified in labware quirks. Handles lid offset behavior during move labware position calculations.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Low - new behavior is being gated to this specific use case currently, both by the labware type and the intended module for use. Existing labware stacking behavior has been maintained and is confirmed through test coverage.