feat(protocol-designer): heater-shaker step form tools #16342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
brenthagen,
koji and
ncdiehl11
and removed request for
a team and
brenthagen
jerader
commented
Sep 24, 2024
| showTooltip?: boolean | ||
| } | ||
|
|
||
| export function InputStepFormField( |
There was a problem hiding this comment.
this is copied over from my other 2 PRs since they all need it 😬
jerader
commented
Sep 24, 2024
...col-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/HeaterShakerTools/index.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Sep 24, 2024
koji
reviewed
Sep 24, 2024
jerader
commented
Sep 25, 2024
Comment on lines
+108
to
+110
| const labwareOnAdapterId = Object.values(labwares).find( | ||
| lw => lw.slot === labware.id | ||
| )?.id |
There was a problem hiding this comment.
fixes a bug with the long labware name
koji
reviewed
Sep 25, 2024
...col-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/HeaterShakerTools/index.tsx
Show resolved
Hide resolved
jerader
force-pushed
the
pd_hs-tools
branch
from
c05fb7f to
6065c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-811
Overview
Wires up the heater-shaker step form tools
There is 1 follow up: https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=10435-664437&node-type=instance&t=OvRfy742rLJPTEX2-0 basically, the heater-shaker set timer fields need to be merged into 1. It will be easier to add that behavior after this PR merges: #16328
Test Plan and Hands on Testing
Test that the fields work as expected for 1 heater-shaker and multi heaters-shakers (To add multi heater-shakers, you need to enable the MoaM feature flag). The timer field does not work yet!!! See the follow up ticket attached.
Changelog
CheckcomponentRisk assessment
low