feat(app): add localization feature flag #16341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the localization feature flag to put localization dev work behind closes PLAT-496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the localization feature flag to put localization dev work behind, the initial zh translation assets, and temp language toggles to enable dev work. For now, when the feature flag is enabled, the desktop language toggle is in the app settings advanced tab, ODD in the robot settings page. These will be removed when designs are implemented.
closes PLAT-496, re PLAT-493
Test Plan and Hands on Testing
manually verified the temp language setting toggle changes the i18n language.
Changelog
Review requests
give the language toggles a smoke test
Risk assessment
low