refactor(app): untangle the rest of the device hooks #16336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no functional reason this should only accept module prep commands.
These look pretty silly sitting next to each other. We should probably fix that
This takes a full protocol, which is why it's here. Could see an argument for it being in local-resources somewhere too.
Let's move useRunCalibrationStatus out into resources! A couple hours later, we have now moved a whole bunch of hooks dealing with currently attached hardware, current calibration status, and also the thing that gives you the appropriate analysis for a run id out into a series of places, and also moved around the code that gets you pipette specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of the first PR, untangle the remainder of the usage of hooks from
app/src/organisms/Devicesinapp/src/organisms/ODD- this is in preparation for an eventual move of devices toapp/src/organisms/Desktop.Changes only to file locations, import paths, and mock paths.
There are some remaining UI elements that are pulled out of devices that we'll have to do something about, and there's actually some stuff in the ODD namespace that's used in the Devices namespace, but this is a solid start.