feat(api): Make gripper errors nonfatal #16320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not seem to handle the case where the gripper drops the labware in transit.
Resolve conflicts in api/src/opentrons/protocol_engine/commands/move_labware.py
SyntaxColoring
commented
Sep 26, 2024
Comment on lines
+180
to
+182
| # todo(mm, 2024-09-26): This currently raises a lower-level 2015 FailedGripperPickupError. | ||
| # Convert this to a higher-level 3001 LabwareDroppedError or 3002 LabwareNotPickedUpError, | ||
| # depending on what waypoint we're at, to propagate a more specific error code to users. |
There was a problem hiding this comment.
Alternatively, we could consolidate 3001 and 3002.
SyntaxColoring
commented
Sep 26, 2024
SyntaxColoring
commented
Sep 26, 2024
SyntaxColoring
commented
Sep 26, 2024
| class Aspirate(BaseCommand[AspirateParams, AspirateResult, ErrorOccurrence]): | ||
| class Aspirate(BaseCommand[AspirateParams, AspirateResult, OverpressureError]): |
There was a problem hiding this comment.
Unrelated fix, just making sure OverpressureError shows up in these commands' OpenAPI specs.
|
The failing snapshot test is an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-714.
Test Plan and Hands on Testing
Changelog
Catch some exceptions in the gripper part of
MoveLabwareImplementationand turn them into a new defined error,errorType: "gripperMovement".Review requests
See comments below.
Risk assessment
Medium.