Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(robot-server): Release backport: Work around tests hanging because server shutdown is hanging #16319

Conversation

SyntaxColoring
Copy link
Contributor

This is the same exact thing as #16317, but targeting the release branch.

The release branch is not currently showing this problem. This is preemptive to, hopefully, avoid tests on the release branch starting to fail at an annoying time.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner September 20, 2024 17:41
@SyntaxColoring SyntaxColoring changed the title chore(robot-server): Release backport: Work around test_reset.py hanging because server shutdown is hanging chore(robot-server): Release backport: Work around tests hanging because server shutdown is hanging Sep 20, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I think we should merge it for another alpha, but there's a good chance we'll push through this release without another alpha in which case I think tagging the same commit as the final alpha is worth holding off.

@y3rsh
Copy link
Member

y3rsh commented Sep 27, 2024

Thanks @SyntaxColoring
closing this one. I see #16317 merged to edge.

@y3rsh y3rsh closed this Sep 27, 2024
@SyntaxColoring SyntaxColoring deleted the work_around_hanging_reset_test_cherry_pick branch September 27, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants