volume at arbitrary height for most above spherical section heights

[caila-marashaj]

Overview

Here are the protocol engine functions to find the volume or height at any arbitrary height/volume within a well.

Changelog

• add functions to find non-border heights and volumes in geometry.py
• logic to look through every section of a well for our target height/volume
• SphericalSegment.radius_of_curvature should have been radiusOfCurvature
• added a height to volume function using the volume-of-a-frustum formula

TODO

I'm going to add tests in a follow-up pr if that's alright. I want to get these functions merged first though so I can unblock Peter's pr

[ryanthecoder]

🥇

[SyntaxColoring]

1. This doesn't look like it's currently used for anything. It sounds like that's intentional, just making sure.

2. Is this docstring right? The function and variable names make it sound like it's supposed to return a height, not a volume.

3. Assuming that this is supposed to return a height, given a volume and top and bottom areas:

   I don't think this is mathematically correct for the kinds of frusta that we have. Experimentally, it looks correct for pyramidal frusta but not for non-pyramidal frusta. I can prepare a CAD demo in a sec.

   This might be the same thing that we (@caila-marashaj+@ryanthecoder+me) talked about a few weeks ago in the office. There are "frustum formulas", but if you look at their precise definitions and conditions of use, they only describe pyramidal frusta, and well shapes are frequently not pyramidal.

[SyntaxColoring]

Recap from call:

• Yeah, we think the math is inapplicable, and we'll delete this for now.
• The plan was for this to help with EXEC-712. We'll make sure the pyramidal assumption hasn't leaked into the rest of the math there.
• I haven't reviewed the rest of this, but LGTM given @ryanthecoder's approval.

See thread above