fix(app): use css grid for run setup accordion transition #16296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses css grid's grid-template-rows property to transition to the height of content when expanding and collapsing the run setup step accordion closes RQA-2901
brenthagen
requested review from
TamarZanzouri,
a team,
ncdiehl11 and
koji
and removed request for
a team,
TamarZanzouri and
ncdiehl11
koji
reviewed
Sep 19, 2024
| @@ -7,6 +7,7 @@ export const DISPLAY_FLEX = 'flex' | |||
| export const DISPLAY_TABLE = 'table' | |||
| export const DISPLAY_TABLE_ROW = 'table-row' | |||
| export const DISPLAY_TABLE_CELL = 'table-cell' | |||
| export const DISPLAY_GRID = 'grid' | |||
koji
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've been implementing the expanding/collapsing run setup step accordion transition using a
max-heightapproach that isn't ideal because it limits the height of content. When protocols have a large number of labware, content in the labware step overflows.This is a well-known problem without a clear solution until recently: since chromium 107 added support, we can now use css grid's
grid-template-rowsproperty to transition to the height of content.closes RQA-2901
Screen.Recording.2024-09-18.at.4.42.50.PM.mov
Test Plan and Hands on Testing
manually verified the transition (screen recording); checked the other setup tabs including liquids for regressions
Changelog
Review requests
check out the setup step accordion transition with protocols with lots of labware (see RQA-2901) and lots of liquids as well. check list view and map view.
Risk assessment
low