Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(api): partial pickup static workaround #16290

Merged
merged 3 commits into from
Sep 20, 2024
Merged

docs(api): partial pickup static workaround #16290

merged 3 commits into from
Sep 20, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Update docs and release notes to advise picking up row by row, rather than column by column, when using SINGLE or PARTIAL_COLUMN layouts.

Test Plan and Hands on Testing

  • Sandbox
  • Simulated new code for constructing and using lists of custom pickup locations

Changelog

  • New warnings and code snippets in single and partial column sections.
  • Cleaned up some incorrect or imprecise start and end values.
  • Added API known issue.

Review requests

  • Double check my code.
  • Double check my real-world advice.

Risk assessment

docs only

@ecormany ecormany requested a review from a team as a code owner September 18, 2024 19:29
@ecormany ecormany added docs papi-v2 Python API V2 labels Sep 19, 2024
CaseyBatten
CaseyBatten approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaging here looks solid with regards to static concerns, and I believe aligns with the results of our testing internally.

vegano1
vegano1 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions make sense

@ecormany ecormany merged commit a6b3308 into chore_release-8.0.0 Sep 20, 2024
22 checks passed
@ecormany ecormany deleted the docs-and-notes-static branch September 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyBatten CaseyBatten CaseyBatten approved these changes

@vegano1 vegano1 vegano1 approved these changes

@y3rsh y3rsh Awaiting requested review from y3rsh

@nusrat813 nusrat813 Awaiting requested review from nusrat813

Assignees
No one assigned
Labels
docs papi-v2 Python API V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecormany @vegano1 @CaseyBatten