Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Update absorbance reader driver namespace for byonoy_devices library version 2024.9.0 #16289

Merged
merged 21 commits into from
Sep 23, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Sep 18, 2024

Overview

We got a new 2024.09.0 library update from Byonoy, this pull request updates the function names and error codes to reflect the new library names. This pull request goes in conjunction with this oe-core pr Opentrons/oe-core#167.

Library Introduces the following changes
`There are two major changes.

  • The name of the Python module has been changed to byonoy_devices
  • The Byonoy prefix has been removed from all datatypes, enumerations, and method names.

There are some bug fixes

  • One bug that has been fixed is the vid/pid which was returning wrong values.
  • Another fix is to remove an unintended busy wait when opening devices.
  • A few other improvements

Test Plan and Hands on Testing

  • Make sure we can still open/free the device
  • Make sure we can read the status of the device and info using the poller
  • Make sure we can still update the device

Changelog

  • Change the name of the AbsorbanceHidInterface functions to match that of the new library
  • Change the name of the ErrorCodeNames to match the new library
  • Change the parsing of the serial number to no longer expect REF: in the response.

Review requests

Risk assessment

Low, unreleased

@vegano1 vegano1 requested a review from a team as a code owner September 18, 2024 18:58
@vegano1 vegano1 force-pushed the PLAT-382-update-byonoy-lib branch from 5949035 to fb8b39b Compare September 19, 2024 14:26
@vegano1 vegano1 force-pushed the PLAT-382-update-byonoy-lib branch from fb8b39b to 8417fe3 Compare September 19, 2024 14:31
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah very nice!!!

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and makes sense based on the changes we've discussed that byonoy is making in their nomenclature.

Base automatically changed from PLAT-474-add-multi-readings to edge September 23, 2024 18:53
@vegano1 vegano1 requested a review from a team as a code owner September 23, 2024 18:53
@vegano1 vegano1 merged commit 058854c into edge Sep 23, 2024
35 checks passed
@vegano1 vegano1 deleted the PLAT-382-update-byonoy-lib branch September 23, 2024 19:25
vegano1 added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants