Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(app): add tests for individual advanced setting files #16265

Merged
merged 1 commit into from
Sep 17, 2024
Merged

test(app): add tests for individual advanced setting files #16265

merged 1 commit into from
Sep 17, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Sep 16, 2024

Overview

This PR adds test files for each advanced setting - no source files are touched so if everything passes it shouldn't need much more of a review

@smb2268 smb2268 self-assigned this Sep 16, 2024
@smb2268 smb2268 requested a review from a team as a code owner September 16, 2024 21:23
vegano1
vegano1 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪💪 thank you!

@smb2268 smb2268 merged commit 5d86811 into chore_release-8.0.0 Sep 17, 2024
24 of 26 checks passed
@smb2268 smb2268 deleted the app_quick-transfer-tests branch September 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegano1 vegano1 vegano1 approved these changes

@brenthagen brenthagen Awaiting requested review from brenthagen

Assignees

@smb2268 smb2268

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smb2268 @vegano1