Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): disable save button once clicked on name transfer screen #16235

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Sep 11, 2024

fix RQA-3165

Overview

Because of the variable time it takes to create and save a protocol file, it was possible to press the "Save" button multiple times in rapid succession on the name transfer screen. This PR disables the button once it has been pressed to prevent duplication

Test Plan and Hands on Testing

Created a transfer, selected "save to run later" and named it. Pressed the Save CTA and saw it was immediately disabled
Added test coverage

Changelog

Disable save button once pressed

Review requests

Quick code check

Risk assessment

Low

@smb2268 smb2268 requested a review from a team as a code owner September 11, 2024 17:55
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good,
do we need to do the same when running the quick transfer instead of saving it?

@smb2268
Copy link
Contributor Author

smb2268 commented Sep 11, 2024

Looking good, do we need to do the same when running the quick transfer instead of saving it?

Yeah can't hurt to do the same - I'll add it.

@smb2268 smb2268 merged commit 455d026 into chore_release-8.0.0 Sep 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants