Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): filter qt out of recent runs to show emptyruns tate #16167

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Aug 29, 2024

fix RQA-3130

Overview

If all previous runs are quick transfer runs, the runs were getting filtered out but the empty run state was not displaying. We need to do the run filtration at a higher level to properly show an empty run history on both ODD and desktop

Test Plan and Hands on Testing

On a robot with no run history, run a quick transfer. See that the run dashboard still shows no run history. Ensure that the run dashboard still appears as expected for robots with non-quick transfer runs

Changelog

  1. In RecentProtocolRuns on desktop, use a filtered runs list throughout the file instead of returning a null list item for quick transfer runs
  2. On ODD, add a query for protocols at the top level dashboard and use this to further pair down recentRunsOfUniqueProtocols list

Review requests

Look over code changes

Risk assessment

Low-Med, we should test that adding a query for protocols at the top level of the RobotDashboard doesn't visibly increase loading time

@smb2268 smb2268 self-assigned this Aug 29, 2024
@smb2268 smb2268 requested a review from a team as a code owner August 29, 2024 19:31
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would add too much time when loading recent runs, since it's just filtering out quick runs.

@smb2268 smb2268 merged commit f0d3ab3 into chore_release-8.0.0 Aug 29, 2024
20 checks passed
@smb2268 smb2268 deleted the app_empty-recent-protocols branch August 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants