Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix run cancel redirection, pipette path copy #16166

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Aug 29, 2024

fix RQA-3125, RQA-3126, RQA-3119

Overview

Move post-cancellation of not started run back to useEffect since moving it to onSettled caused a race condition with other navigation logic.
Also fix duplicative copy in pipette path summary and use lodash isEquals when comparing blowout location objects

Test Plan and Hands on Testing

  1. With no trash or waste chute in your deck config, create a quick transfer and look at the blowout location options. Select "Trash bin in A3" and confirm button highlights as expected when it is selected
  2. Initiate a run for a quick transfer protocol and cancel the run before starting. When the cancellation modal closes you should be redirected to the quick transfer details page

Changelog

  1. Remove duplicate "into" copy from pipette path mutli-dispense description
  2. Use lodash.isEquals to check for object equality for blowout location items
  3. Move navigate logic sequence back to useEffect from onSettled so it will happen before the cancellation modal closes

Review requests

Look over changes

Risk assessment

Low

@smb2268 smb2268 requested review from brenthagen and mjhuff August 29, 2024 19:06
@smb2268 smb2268 self-assigned this Aug 29, 2024
@smb2268 smb2268 requested a review from a team as a code owner August 29, 2024 19:06
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@smb2268 smb2268 merged commit a989cb8 into chore_release-8.0.0 Aug 29, 2024
20 checks passed
@smb2268 smb2268 deleted the app_quick-transfer-fix branch August 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants