Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix factory mode advanced setting style #16159

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix(app): fix factory mode advanced setting style #16159

merged 2 commits into from
Aug 29, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 29, 2024 •
edited
Loading

Overview

In robot advanced settings, add divider under 'Factory Mode' advanced setting. Also, align 'Download logs' button to end of flex container.

Closes RQA-3127

Test Plan and Hands on Testing

  • navigate to Flex robot advanced settings page and verify that there is a divider under "Factory Mode" settings
  • verify that "Download logs" button on "Troubleshooting" section is aligned with left text

Flex
Screenshot 2024-08-29 at 12 06 29 PM

OT-2
Screenshot 2024-08-29 at 12 06 36 PM

Changelog

  • add divider
  • realign button

Review requests

see test plan

Risk assessment

low

@ncdiehl11
fix(app): fix factory mode advanced setting style
27e72a8 
In robot advanced settings, add divider under 'Factory Mode' advanced setting. Also, align 'Download
logs' button to end of flex container.

Closes RQA-3127r
@ncdiehl11 ncdiehl11 self-assigned this Aug 29, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 29, 2024 16:16
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 29, 2024 16:16
@ncdiehl11 ncdiehl11 requested review from mjhuff and removed request for a team August 29, 2024 16:16
@ncdiehl11 ncdiehl11 requested a review from jerader August 29, 2024 17:15
mjhuff
mjhuff approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@ncdiehl11 ncdiehl11 merged commit 7459249 into chore_release-8.0.0 Aug 29, 2024
25 checks passed
@ncdiehl11 ncdiehl11 deleted the app_fix-oem-advanced-settings-style branch August 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @mjhuff