Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): disable rerun until data is available #16154

Merged

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Aug 28, 2024

We need the full run data to rerun a run, but that can be pretty significantly delayed on USB. Add a loading state for that button (disabled with a new tooltip) in that case.

Close RQA-3117

testing

  • does this fix the issue
  • why is the tooltip like that

@sfoster1 sfoster1 requested a review from a team as a code owner August 28, 2024 21:00
@sfoster1 sfoster1 requested review from brenthagen and mjhuff and removed request for a team August 28, 2024 21:00
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense to me. Thanks for fixing!

We need the full run data to rerun a run, but that can be pretty
significantly delayed on USB. Add a loading state for that
button (disabled with a new tooltip) in that case.

Close RQA-3117
@sfoster1 sfoster1 force-pushed the rqa-3117-disable-rerun-until-data-available branch from 6a0e5fd to 2da2418 Compare August 29, 2024 17:03
@sfoster1 sfoster1 merged commit f208e93 into chore_release-8.0.0 Aug 29, 2024
25 checks passed
@sfoster1 sfoster1 deleted the rqa-3117-disable-rerun-until-data-available branch August 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants