Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): provide labware schema 3 definitions if possible #16148

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Aug 28, 2024

Overview

Now that we have labware schema 3 merged, let's provide labware schema 3 definitions when they're available, and otherwise default to schema 2 like before.

Changelog

  • In _get_path_to_labware, see if a folder matching the labware's name exists, and if not return the definition in the schema 2 folder
  • adjust get_all_labware_definitions to stay pointed at the schema 2 folder because I'm unsure where that gets used

Review Requests

Let me know if this might break anything unexpected

@caila-marashaj caila-marashaj requested a review from a team as a code owner August 28, 2024 15:02
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now That's What I Call Labware (Volume 3)

Just remove that # here comment, and LGTM.

That, plus some nonessential suggestions:

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (58a7d19) to head (dde895a).
Report is 81 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #16148       +/-   ##
===========================================
+ Coverage   63.31%   92.43%   +29.12%     
===========================================
  Files         300       77      -223     
  Lines       15773     1283    -14490     
===========================================
- Hits         9986     1186     -8800     
+ Misses       5787       97     -5690     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
hardware ?
shared-data ?
system-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 223 files with indirect coverage changes

@caila-marashaj caila-marashaj merged commit ce66744 into edge Aug 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants