-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): provide labware schema 3 definitions if possible #16148
Conversation
Co-authored-by: Max Marrone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now That's What I Call Labware (Volume 3)
Just remove that # here
comment, and LGTM.
That, plus some nonessential suggestions:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16148 +/- ##
===========================================
+ Coverage 63.31% 92.43% +29.12%
===========================================
Files 300 77 -223
Lines 15773 1283 -14490
===========================================
- Hits 9986 1186 -8800
+ Misses 5787 97 -5690
Flags with carried forward coverage won't be shown. Click here to find out more. |
Overview
Now that we have labware schema 3 merged, let's provide labware schema 3 definitions when they're available, and otherwise default to schema 2 like before.
Changelog
_get_path_to_labware
, see if a folder matching the labware's name exists, and if not return the definition in the schema 2 folderget_all_labware_definitions
to stay pointed at the schema 2 folder because I'm unsure where that gets usedReview Requests
Let me know if this might break anything unexpected