Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fall back to stored protocol analysis for pipette data #16144

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Aug 27, 2024

fix RQA-3111

Overview

In the run setup instrument section on a Flex we are falling back on the storedProtocolAnalysis if the robot analysis is pending for the gripper info but not for pipette info. This is confusing for the user since they see the gripper immediately when viewing run setup but the pipettes don't populate until the robot analysis is completed

Test Plan and Hands on Testing

Start setup on a protocol with both pipettes and a gripper, see that the pipettes and gripper populate at the same time in the instrument section

Changelog

Fall back on storedProtocolAnalysis if mostRecentCompletedAnalysis does not exist

Review requests

Look over changes

Risk assessment

Low

@smb2268 smb2268 requested review from brenthagen and mjhuff August 27, 2024 20:23
@smb2268 smb2268 self-assigned this Aug 27, 2024
@smb2268 smb2268 requested a review from a team as a code owner August 27, 2024 20:23
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense!

@smb2268 smb2268 changed the title fix(app): fallback to stored protocol analysis for pipette data fix(app): fall back to stored protocol analysis for pipette data Aug 27, 2024
@smb2268 smb2268 merged commit f4d512d into chore_release-8.0.0 Aug 27, 2024
26 checks passed
@smb2268 smb2268 deleted the app_pipette-calibration-analysis branch August 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants