fix(app): No longer dismiss run if canceled while running on ODD #16142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
commented
Aug 27, 2024
| @@ -55,9 +55,17 @@ export function ConfirmCancelRunModal({ | |||
| dismissCurrentRun, | |||
| isLoading: isDismissing, | |||
| } = useDismissCurrentRunMutation({ | |||
| onSuccess: () => { | |||
| if (isQuickTransfer && !isActiveRun) { | |||
There was a problem hiding this comment.
This mutation will now only be called if !isActiveRun is true
smb2268
commented
Aug 27, 2024
| @@ -251,15 +251,10 @@ export function RunSummary(): JSX.Element { | |||
| }, [isRunCurrent, enteredER]) | |||
|
|
|||
| const returnToQuickTransfer = (): void => { | |||
| if (!isRunCurrent) { | |||
| closeCurrentRunIfValid(() => { | |||
There was a problem hiding this comment.
closeCurrentRunIfValid checks for !isRunCurrent and calls the passed in callback regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3100, RQA-3098
Overview
This PR changes the behavior of a run cancellation initiated on ODD. Previous behavior stopped the run, dismissed (or un-currented) the run, and then if the run was not yet started we'd manually redirect back to the protocols or quick transfer page. Now, we'll only dismiss the run if it has not yet started. This will fix the drop tip wizard not opening as expected after run cancellation.
Test Plan and Hands on Testing
While testing this, you may run into https://opentrons.atlassian.net/browse/RQA-3109 which is not fixed in this PR. If this is too difficult to test because of the hanging cancellation modal, we can wait to test and merge until that ticket is resolved.
Changelog
dismissCurrentRuncall inConfirmCancelRunModalso that it is only called if a run is not activeonSettledcallback ofuseDismissCurrentRunMutationreturnToQuickTransferfunction -closeCurrentRunIfValidhandles the current run functionality for usReview requests
Look over code changes
Risk assessment
Medium - we do not think this will have any side effects but it is possible that there are places in the app where we expect a run to be dismissed after ODD cancellation