Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add 4th slot column label for magblock + staging area #16138

Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 27, 2024

Overview

Add condition for showing 4th slot column label for magnetic block with staging area fixture

Closes RQA-2838

Test Plan and Hands on Testing

  • Start with a fresh deck configuration
  • Add magnetic block with staging area area fixture to right column of deck configuration
  • Verify that 4th slot column label shows
  • Remove above fixture and add only magnetic block to right column (without staging area)
  • Verify that 4th slot column does not show
Screenshot 2024-08-27 at 11 49 18 AM Screenshot 2024-08-27 at 11 49 58 AM

Changelog

  • add check for magblock with staging area to SlotLabels show4thColumn prop condition

Review requests

see test plan

Risk assessment

low

Add condition for showing 4th slot column label for magnetic block with staging area fixture

Closes RQA-2838
@ncdiehl11 ncdiehl11 self-assigned this Aug 27, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 27, 2024 15:58
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 27, 2024 15:58
@ncdiehl11 ncdiehl11 requested review from TamarZanzouri, jerader, a team and koji and removed request for a team August 27, 2024 15:58
@ncdiehl11 ncdiehl11 merged commit 2d34885 into chore_release-8.0.0 Aug 28, 2024
55 checks passed
@ncdiehl11 ncdiehl11 deleted the components_fix-deck-configurator-slot-labels branch August 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants