Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix SecondaryButton disabled cursor #16111

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(components): fix SecondaryButton disabled cursor #16111

merged 1 commit into from
Aug 27, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 23, 2024 •
edited
Loading

Overview

add pointer cursor style to disabled pseudo class for SecondaryButton

RQA-3069

Test Plan and Hands on Testing

  • begin a run that will produce a blocked state for LPC (incorrect instruments/modules attached, for example)
  • on run setup, expand LPC step
  • hover over "confirm offsets" button and verify that cursor is default rather than pointer

Changelog

  • update SecondaryButton disabled cursor

Review requests

see test plan

Risk assessment

low

@ncdiehl11
fix(components): fix SecondaryButton disabled cursor
71b09ef 
add pointer cursor style to disabled pseudo class for SecondaryButton

RQA-3069
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 23, 2024 15:22
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 23, 2024 15:22
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team August 23, 2024 15:22
koji
koji approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit a054baf into chore_release-8.0.0 Aug 27, 2024
54 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_secondarybutton-disabled-cursor branch August 27, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader jerader is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji