fix(app): Fix continuing with no tips selected during Error Recovery #16108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3083
Overview
During tip selection in Error Recovery, if a user clicks around enough, it's sometimes possible to get into a state in which no tips are selected. The user then may proceed with recovery, failing recovery since no tips are selected.
This PR just adds some safeguards, so if a user does try to proceed with no active tips selected, the proceed CTAs are disabled. On the ODD, the user can't close the modal until they select tips. On the desktop (and also on the ODD technically, although this is unreachable due to the modal disabled state), the "Pick up tips" button is disabled.
Although a more direct solution would be to debug the state update handler, this bug is pretty difficult to repro in practice, and it seems to be somewhat difficult to solve for without delving into
WellLocation
, which is a pretty high risk component to be messing with right before a release. This fix is low risk, and adding these kind of disabled states if users get into weird spots is probably good UI practice, anyway.Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low