Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix continuing with no tips selected during Error Recovery #16108

Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Aug 23, 2024

Closes RQA-3083

Overview

During tip selection in Error Recovery, if a user clicks around enough, it's sometimes possible to get into a state in which no tips are selected. The user then may proceed with recovery, failing recovery since no tips are selected.

This PR just adds some safeguards, so if a user does try to proceed with no active tips selected, the proceed CTAs are disabled. On the ODD, the user can't close the modal until they select tips. On the desktop (and also on the ODD technically, although this is unreachable due to the modal disabled state), the "Pick up tips" button is disabled.

Although a more direct solution would be to debug the state update handler, this bug is pretty difficult to repro in practice, and it seems to be somewhat difficult to solve for without delving into WellLocation, which is a pretty high risk component to be messing with right before a release. This fix is low risk, and adding these kind of disabled states if users get into weird spots is probably good UI practice, anyway.

Test Plan and Hands on Testing

  • Verified that the X button on the ODD during tip selection disappears when no tips are selected (mash tip selection like 100x to repro this).
  • Verified that the "Pick up tips" button the desktop during tip selection disappears when no tips are selected (see above).

Changelog

  • Fixed a bug in which users may proceed through error recovery with no tips selected.

Review requests

  • Unless someone wants to test this themselves, I will test this on Tuesday in office (and merge it then if approval comes before Tuesday).

Risk assessment

low

@mjhuff mjhuff requested a review from a team August 23, 2024 13:09
@mjhuff mjhuff requested a review from a team as a code owner August 23, 2024 13:09
@mjhuff mjhuff requested review from smb2268 and removed request for a team and smb2268 August 23, 2024 13:09
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense to me.

@mjhuff mjhuff merged commit 73bee80 into chore_release-8.0.0 Aug 27, 2024
20 checks passed
@mjhuff mjhuff deleted the app_recovery-disable-continue-when-no-tips branch August 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants