Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): fix syntax error in cherrypicking use case #16100

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Thanks to @alexjoel42 for noticing this syntax error in the cherrypicking use case. I think I tried to shift loading the trash bin lower in the protocol and left it one line short of where it needed to go.

Test Plan and Hands on Testing

I simulated the whole code block, no modifications except indentation, promise.

Changelog

🆙

Risk assessment

none

@ecormany ecormany requested a review from a team as a code owner August 22, 2024 18:05
@ecormany ecormany requested a review from alexjoel42 August 22, 2024 18:05
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore_release-8.0.0@3f01d7c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.0.0   #16100   +/-   ##
======================================================
  Coverage                       ?   63.28%           
======================================================
  Files                          ?      300           
  Lines                          ?    15780           
  Branches                       ?        0           
======================================================
  Hits                           ?     9986           
  Misses                         ?     5794           
  Partials                       ?        0           
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ecormany ecormany merged commit 9d98cfc into chore_release-8.0.0 Aug 22, 2024
28 checks passed
@ecormany ecormany deleted the docs-csv-syntax-fix branch October 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants