fix(app): fix robotType condition for overflow menu in protocol card #16079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix robotType condition for overflow menu in protocol card close RQA-3066
sfoster1
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix robotType condition for overflow menu in protocol card since robotType is not null even when a protocol gets failed.
the issue was checking Array error size and robotType was
nullwhen an OT-2 protocol was failed.then overflow menu displays
send to robot.Screen.Recording.2024-08-21.at.1.22.45.PM.mov
protocol that is attached to the ticket
close RQA-3066
Test Plan and Hands on Testing
check the following cases
Changelog
Review requests
Risk assessment
low