fix(app): fix never clicking setup tab after the run has started #16072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Aug 20, 2024
mjhuff
force-pushed
the
app_fix-no-run-setup
branch
from
9001de1 to
76fbbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3065 and RQA-3059
Overview
We recently updated the routing logic to the setup tab, but the
useEffectdependency array is a bit overzealous. Let's only do the redirect on the first click only.Current Behavior
Screen.Recording.2024-08-20.at.2.57.42.PM.mov
Fixed Behavior
Screen.Recording.2024-08-20.at.2.58.19.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
lowwww