Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): liquid presence verification (#15695) #16033

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Aug 16, 2024

Cherry Pick the LLD docs

# Overview

Adding new documentation to describe new Liquid Presence Verification
methods, includes updating docstrings. Sandbox links below.

The JIRA ticket is
[RTC-148](https://opentrons.atlassian.net/browse/RTC-148).


# Test Plan

Review the new docs.

# Changelog

**New**
Adds a new H2 section, [Liquid Presence
Verification](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/pipettes/loading.html#liquid-presence-verification)
to the page, Loading Pipettes (`loading.rst`). Includes two H3
subsections:

- [Enable LPV
Globally](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/pipettes/loading.html#enable-lpv-globally)
- [Turning LPV Off and
On](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/pipettes/loading.html#turing-lpv-off-and-on)

**New**
Adds two new H2 sections to the page, Liquid Control (`liquids.rst`):

- [Detect
Liquids](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/basic_commands/liquids.html#detect-liquids)
- [Require
Liquids](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/basic_commands/liquids.html#require-liquids)

**Revisions/Additions**
Small changes to docstrings for:

- `liquid_presence_detection`, an argument of
[load_instrument](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/new_protocol_api.html?highlight=load_instrument#opentrons.protocol_api.ProtocolContext.load_instrument)
-
[detect_liquid_presence](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/new_protocol_api.html?highlight=detect_liquid_presence)
in v2 Reference.
-
[require_liquid_presence](http://sandbox.docs.opentrons.com/docs-liquid-presence-detection/v2/new_protocol_api.html?highlight=require_liquid_presence)

# Review requests

Take a look and or before adding others.

# Risk assessment

Low. Docs changes only.


[RTC-148]:
https://opentrons.atlassian.net/browse/RTC-148?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Edward Cormany <[email protected]>
@y3rsh y3rsh self-assigned this Aug 16, 2024
@y3rsh y3rsh requested a review from a team as a code owner August 16, 2024 15:46
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore_release-8.0.0@216d031). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.0.0   #16033   +/-   ##
======================================================
  Coverage                       ?   63.17%           
======================================================
  Files                          ?      288           
  Lines                          ?    15279           
  Branches                       ?        0           
======================================================
  Hits                           ?     9652           
  Misses                         ?     5627           
  Partials                       ?        0           
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒

@y3rsh y3rsh merged commit af14eb8 into chore_release-8.0.0 Aug 20, 2024
29 checks passed
@y3rsh y3rsh deleted the cherry-pick-lld-docs branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants