fix(robot-server, app): Fix ODD routing back to previous screen #16021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3036 and RQA-3038
Overview
The recent react-router update exposed an existing bug: MQTT did not properly publish a refetch to
runs/:runId
after a client sends aPATCH
toruns/:runId
. Although the exact reasoning concerning why the migration fromhistory.push
tonavigate
exposes this problem is unknown, this PR provides the necessary publish event to the app's top level redirection logic and prevents redirection back to the previous route. Note that this does mean we have to account for noticible client latency now, so this PR also adds loading state when "return to dashboard" is clicked.Screen.Recording.2024-08-15.at.1.22.57.PM.mov
Test Plan and Hands on Testing
PATCH
esrun/:runId
.Changelog
Risk assessment
low