Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): add cursor and pageLength to GET /commandErrors #16019

Merged
merged 10 commits into from
Aug 15, 2024
Merged

fix(app): add cursor and pageLength to GET /commandErrors #16019

merged 10 commits into from
Aug 15, 2024

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Aug 15, 2024 •
edited by jira bot
Loading

Overview

closes RQA-3031 and RQA-3047.
pass in cursor and page length to get run command errors.

Test Plan and Hands on Testing

  • upload a protocol that will enter ER.
  • make sure there are a few errors to show.
  • at the end of the run make sure when you click 'view error details' is showing the full error list.

Changelog

added cursor and pageLength to GET request.

Risk assessment

None.

@TamarZanzouri TamarZanzouri requested a review from a team as a code owner August 15, 2024 17:12
@TamarZanzouri TamarZanzouri requested review from smb2268 and mjhuff and removed request for a team and smb2268 August 15, 2024 17:12
mjhuff
mjhuff requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need this on the ODD, too!

@TamarZanzouri TamarZanzouri requested a review from mjhuff August 15, 2024 17:53
@mjhuff mjhuff force-pushed the RQA-3031-error-list-returns-last branch from 2513f3d to 2f43fb2 Compare August 15, 2024 19:15
mjhuff
mjhuff approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@TamarZanzouri TamarZanzouri merged commit 038abba into chore_release-8.0.0 Aug 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamarZanzouri @mjhuff