Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api, shared-data): Update LLD settings after testing #16018

Conversation

andySigler
Copy link
Contributor

Overview

  • Small adjustments to all pipettes' minHeight values (all of them got a bit bigger)
  • 1ch and 8ch pipettes tested better at 15 mm/sec (as opposed to 20 mm/sec)

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from a team as a code owner August 15, 2024 17:50
@andySigler andySigler requested review from TamarZanzouri and removed request for a team August 15, 2024 17:50
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the tests are fixed

@andySigler andySigler merged commit d93cace into chore_release-8.0.0 Aug 19, 2024
42 checks passed
@andySigler andySigler deleted the chore-api-shared-data-update-lld-settings-after-testing branch August 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants