Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix choose csv file radio button size and text display issue #16004

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 14, 2024

Overview

Add -webkit-box to RadioButton since it was created for only RobotSettings's one line button.
Switched flex: 1 to fixed width and truncated a file name with truncateString (max chars 52 + keep displaying the file extension).

close RQA-3003

after
Screenshot 2024-08-15 at 6 15 38 AM

Test Plan and Hands on Testing

Changelog

  • update RadioButton components
  • modify ChooseCSVFile styling

Review requests

  1. push this branch to Flex
  2. check this branch with Josh's protocol and csv files
  3. create a long name csv file and load it via USB drive and check RadioButton

Risk assessment

low

fix choose csv file radio button size and text

close RQA-3003
@koji koji requested a review from ncdiehl11 August 14, 2024 21:31
@koji koji marked this pull request as ready for review August 14, 2024 21:33
@koji koji requested a review from a team as a code owner August 14, 2024 21:33
@koji koji removed the request for review from a team August 14, 2024 21:34
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Koji! Thanks for fixing.

@koji koji merged commit 62ca39e into chore_release-8.0.0 Aug 15, 2024
36 checks passed
@koji koji deleted the fix_RQA-3003 branch August 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants