fix(app): fix run preview when full-screened #16000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3005
Overview
We were hardcoding widths for the default app sizing but not considering custom sizing. Although we don't really support non-default dimensions in a lot of ways, it's something that would be probably be a good idea to refactor towards. Ideally, we could do something like
height:100%here and have it work out, but we need toposition:fixedthe protocol run header, add more containers, handle the overflows correctly, and insure every child component still looks correct, which produces a much larger bug surface. The viewport approach is a bit more direct.Current Behavior
Screen.Recording.2024-08-14.at.2.30.33.PM.mov
Fixed Behavior
Screen.Recording.2024-08-14.at.2.29.57.PM.mov
Test Plan and Hands on Testing
Risk assessment
low