fix(api): Copy config lld bug #15986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
requested review from
TamarZanzouri
and removed request for
a team
caila-marashaj
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
on specifically the 96 channel we were seeing that the first run would sometimes result in the pipette going ~2mm too far on liquid probe.
Root cause ended up being that we were adjusting the plunger speed used in calculations AFTER doing some of the calculations. It ended up only happening on the first probe after a robot-server restart because after the first run the setting was updated in a reference to the config instead of a copy and that is why it would pass in subsequent runs.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment