Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Labware List Item responsiveness and stacking order #15982

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Aug 13, 2024

Overview

This PR makes the labware list items responsive so the divider will be full width regardless of screen size. It also shows the "nested labware def" at the top of the labware list instead of in the middle

Test Plan and Hands on Testing

I tested this with multiple window widths and stacked labware configurations

Screen Shot 2024-08-13 at 11 05 23 AM

Changelog

  1. Remove width items from flex containers and fix the grid widths so that the list items will be responsive
  2. Swap order of "nested labware def" - this is the top level labware that is "nested on" the adapter or module

Review requests

Test the branch out

Risk assessment

Low

@smb2268 smb2268 self-assigned this Aug 13, 2024
@smb2268 smb2268 requested a review from a team as a code owner August 13, 2024 15:10
@smb2268 smb2268 requested review from jerader, brenthagen, ncdiehl11 and a team and removed request for a team August 13, 2024 15:10
@smb2268 smb2268 changed the title App fix labware list fix(app): Labware List Item responsiveness and stacking order Aug 13, 2024
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good 👍

@smb2268 smb2268 merged commit 312236e into chore_release-8.0.0 Aug 13, 2024
20 checks passed
@smb2268 smb2268 deleted the app_fix-labware-list branch August 13, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants