Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): shrink Setup Robot Modal links to fit content #15974

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 12, 2024

Overview

On modal produced by desktop app DeviceLanding "See how to setup a new robot" link, shrink link clickable area to fit content.

Closes RQA-2961

Test Plan and Hands on Testing

  • On Desktop, navigate to Devices tab and click "See how to setup a new robot" at top of page
  • On modal, move cursor over whitespace to the right of links and verify that the space is not clickable
Screen.Recording.2024-08-12.at.4.40.44.PM.mov

Changelog

  • fit link to content

Review requests

see test plan

Risk assessment

low

On modal produced by desktop app `DeviceLanding` "See how to setup a new robot" link, shrink link
clickable area to fit content.

Closes RQA-2961
@ncdiehl11 ncdiehl11 self-assigned this Aug 12, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 12, 2024 20:41
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 12, 2024 20:41
@ncdiehl11 ncdiehl11 requested review from mjhuff and a team and removed request for a team August 12, 2024 20:41
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ncdiehl11 ncdiehl11 merged commit ffd1c16 into chore_release-8.0.0 Aug 12, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-setup-robot-link-style branch August 12, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants