-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol-designer): add some styling to navigation bar #15972
Conversation
import { actions as loadFileActions } from './load-file' | ||
import type { ThunkDispatch, RouteProps } from './types' | ||
|
||
export function NavigationBar({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did try naming this Navigation
but got confusing since react-router-dom has navigate
. SOOO decided to add bar
to the end so at least its a unique name to the nav bar in the app
const NavbarLink = styled(NavLink)` | ||
color: ${COLORS.black90}; | ||
text-decoration: none; | ||
align-self: ${ALIGN_STRETCH}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! i couldn't figure out what was happening, didn't see this align-self i added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments on styling but overall looks good!
new create protocol's ui is sick!
closes AUTH-624
Overview
add some temporary styling to the nav bar and rename to
navigationBar
Test Plan and Hands on Testing
turn on the redesign feature flag and look at the navigation after clicking on "create new protocol". It is not final but wanted to add a bit of design. We will have to go back and add the breadcrumbs and remove the other routes from the nav, it would be good to work on that after the Protocol Overview page is a bit developed
Changelog
refactor navigation slightly so there is some styling
Review requests
see test plan
Risk assessment
low