Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, components): update style of LabwareStackModal #15971

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 12, 2024

Overview

Updates style of LabwareStackModal component according to design changes

Closes RQA-2971

Test Plan and Hands on Testing

  • Begin protocol setup for a protocol with stacked entities (example)
  • On desktop, proceed to Labware setup > map view
  • Click labware stacks and verify that if there is only a single labware rendered, it is not blue highlighted
  • Verify that right hand elements (images/renders) are aligned center
  • Repeat above for ODD and verify that modal is not scrollable

Changelog

  • remove highlight from labware if it is not part of a stack
  • align all right side content (images/labware renders) to center
  • update HeaterShaker image
  • fix scrolling issue on ODD

Review requests

see test plan

Risk assessment

low

Updates style of `LabwareStackModal` component according to design changes
@ncdiehl11 ncdiehl11 self-assigned this Aug 12, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 12, 2024 18:32
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 12, 2024 18:32
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ncdiehl11 ncdiehl11 merged commit 113b3aa into chore_release-8.0.0 Aug 13, 2024
34 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-labwarestackmodal-style branch August 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants