Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components, app): rename input field in components #15964

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 12, 2024

Overview

move input field from app to components and rename input field in components into legacy input field

close AUTH-646 partially

moving input filed from app to components will be achieve after AUTH-655.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

move inputfield from app to components and rename inputfield in components into legacyinputfield

close AUTH-646
@koji koji requested review from jerader and ncdiehl11 August 12, 2024 04:26
@koji koji changed the title refactor(components, app): move input field from app to components refactor(components, app): rename input field in components Aug 12, 2024
@koji koji marked this pull request as ready for review August 12, 2024 04:50
@koji koji requested review from a team as code owners August 12, 2024 04:50
@koji koji removed request for a team August 12, 2024 04:50
@@ -57,7 +57,7 @@ export interface InputFieldProps {
* @deprecated Use `InputField` in App/atoms instead
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you modify this comment to remove the App/atoms? Since InputField will be moved in a follow up

Suggested change
* @deprecated Use `InputField` in App/atoms instead
* @deprecated Use `InputField`

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@koji koji merged commit 3c48aa1 into edge Aug 12, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants